Commit graph

9 commits

Author SHA1 Message Date
Vartan Benohanian
d128a7c4f7 Remove "before" field from Response
Listing responses only ever contain a non-empty "before" field when the
"count" parameter is provided, which is only useful for the HTML
website, not really needed for API clients

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-29 14:19:32 -04:00
Vartan Benohanian
15ee94fbbe Replace fmt.Sprint with strconv.Itoa, specify slice capacity
Uber's Go style guide outlines a slight performance benefit when using
strconv over fmt:
dc025303c1/style.md (prefer-strconv-over-fmt)

Also specifiying slice capacity when it is known beforehand:
dc025303c1/style.md (specifying-slice-capacity)

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-29 14:01:21 -04:00
Vartan Benohanian
022cfd5cb1 Edit error messages
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-29 13:40:34 -04:00
Vartan Benohanian
def7e3bdb7 Chage NewRequest methods, add multi description kind to thing
Since Reddit's API accepts form data as the body for most of its
endpoints, it made sense to me to make the default NewRequest method
set the request body as form data (if provided of course). The
NewJSONRequest method can accept a JSON body.

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-09 23:02:06 -04:00
Vartan Benohanian
ffcc906c07 Add Listing/KarmaList to thing struct, tweak anonymous structs
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-01 22:35:28 -04:00
Vartan Benohanian
b42aa44c44 Add Multi to thing struct
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-31 12:51:45 -04:00
Vartan Benohanian
2a1806ec33 Revamp listing decoding, include after/before anchors in response
Now, instead of returning an object containing a list of results + the
anchors, we return just the list. The anchors are available in the
response object. Much cleaner this way in my opinion

go-github and godo do it this way too. They include some meta
information in the returned response objects

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-29 14:23:37 -04:00
Vartan Benohanian
73945e9aae Edit comments
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-27 18:49:30 -04:00
Vartan Benohanian
f86a559d76 Move everything to new reddit/ folder
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-20 14:37:59 -04:00
Renamed from post.go (Browse further)